[
https://issues.apache.org/jira/browse/KNOX-1995?focusedWorklogId=301388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301388
]
ASF GitHub Bot logged work on KNOX-1995:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/19 17:51
Start Date: 26/Aug/19 17:51
Worklog Time Spent: 10m
Work Description: moresandeep commented on pull request #135: KNOX-1995 -
If a rule doesn't match, shouldn't ERROR and return null
URL: https://github.com/apache/knox/pull/135#discussion_r317719089
##########
File path:
gateway-provider-rewrite/src/main/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteProcessor.java
##########
@@ -165,7 +165,6 @@ public Template rewrite( Resolver resolver, Template
inputUri, Direction directi
}
} else {
LOG.failedToRewriteUrl( inputUri, direction, effectiveRuleName,
stepStatus );
- outputUri = null;
Review comment:
Not sure what the implications are if we return `outputUri =
context.getCurrentUrl()` instead of `null`, it looks a bit risky to me to break
the assumption that rewriter.rewrite() function on failure returns a non null
value.
`JsonUrlRewriteFilterReader.filterValueString()` seems to ignore that
contract causing NPE. it might be safe to just check `output != null` before
calling `output.pattern()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 301388)
Time Spent: 20m (was: 10m)
> If a rule doesn't match, shouldn't ERROR and return null
> --------------------------------------------------------
>
> Key: KNOX-1995
> URL: https://issues.apache.org/jira/browse/KNOX-1995
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently when an explicit rule doesn't match, we are throwing an ERROR and
> returning null. This causes NPEs later in the flow and instead should match
> the behavior of a non explicit rule. If the rule doesn't match, log only at
> DEBUG and return the original input.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
