risdenk commented on a change in pull request #149: KNOX-2017 - Making Cloudera
repository available in Knox's parent POM so that Cloudera dependencies are
available in every children project
URL: https://github.com/apache/knox/pull/149#discussion_r326184189
##########
File path: gateway-discovery-cm/pom.xml
##########
@@ -50,26 +45,16 @@
<dependency>
<groupId>com.cloudera.api.swagger</groupId>
<artifactId>cloudera-manager-api-swagger</artifactId>
- <version>${cloudera-manager-api-swagger.version}</version> <!--
or CM version 6.0 and above -->
</dependency>
<dependency>
<groupId>com.squareup.okhttp</groupId>
<artifactId>okhttp</artifactId>
- <version>${okhttp.version}</version>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
<scope>compile</scope>
Review comment:
Remove `<scope>compile</scope>` since that is the default and not needed. (I
know its not directly related but its the same pom file)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
