stoty commented on a change in pull request #148: KNOX-2013 CM discovery - Add Phoenix to auto discovery URL: https://github.com/apache/knox/pull/148#discussion_r327020936
########## File path: gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/phoenix/PhoenixServiceModelGenerator.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.knox.gateway.topology.discovery.cm.model.phoenix; + +import com.cloudera.api.swagger.model.ApiConfigList; +import com.cloudera.api.swagger.model.ApiRole; +import com.cloudera.api.swagger.model.ApiService; +import com.cloudera.api.swagger.model.ApiServiceConfig; +import org.apache.knox.gateway.topology.discovery.cm.ServiceModel; +import org.apache.knox.gateway.topology.discovery.cm.model.AbstractServiceModelGenerator; + +import java.util.Locale; + +public class PhoenixServiceModelGenerator extends AbstractServiceModelGenerator { + + private static final String SERVICE = "AVATICA"; + private static final String SERVICE_TYPE = "PHOENIX"; + private static final String ROLE_TYPE = "PHOENIX_QUERY_SERVER"; + + @Override + public String getService() { + return SERVICE; + } + + @Override + public String getServiceType() { + return SERVICE_TYPE; + } + + @Override + public String getRoleType() { + return ROLE_TYPE; + } + + @Override + public ServiceModel.Type getModelType() { + return ServiceModel.Type.API; + } + + @Override + public boolean handles(ApiService service, ApiServiceConfig serviceConfig, ApiRole role, ApiConfigList roleConfig) { + return getServiceType().equals(service.getType()) && getRoleType().equals(role.getType()); + } + + @Override + public ServiceModel generateService(ApiService service, + ApiServiceConfig serviceConfig, + ApiRole role, + ApiConfigList roleConfig) { + String hostname = role.getHostRef().getHostname(); + String scheme; + String port = getRoleConfigValue(roleConfig, "phoenix_query_server_port"); + // According to upstream docs, phoenix does not support https + scheme = "http"; Review comment: Done. I have also improved on the comment. Thanks for the review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
