risdenk commented on a change in pull request #153: KNOX-2020 AWS federation support added to hadoop-jwt cookie. URL: https://github.com/apache/knox/pull/153#discussion_r327381147
########## File path: gateway-service-knoxsso/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOResource.java ########## @@ -47,6 +50,10 @@ import org.apache.commons.lang3.StringUtils; import org.apache.knox.gateway.audit.log4j.audit.Log4jAuditor; import org.apache.knox.gateway.config.GatewayConfig; +import org.apache.commons.codec.binary.Base64; Review comment: Since we are on Java 8 minimum, should be able to use Base64 from the JDK and not need commons-codec. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
