smolnar82 commented on a change in pull request #164: KNOX-2053 - New REST API
to create/read/update/delete service definitions
URL: https://github.com/apache/knox/pull/164#discussion_r334874859
##########
File path:
gateway-provider-rewrite-common/src/main/java/org/apache/knox/gateway/filter/rewrite/impl/xml/XmlUrlRewriteRulesExporter.java
##########
@@ -59,7 +59,11 @@ public String getFormat() {
}
@Override
- public void store( UrlRewriteRulesDescriptor descriptor, Writer writer )
throws IOException {
+ public Object store(UrlRewriteRulesDescriptor descriptor, Writer writer)
throws IOException {
+ return store(descriptor, writer, false);
+ }
+
+ public Object store( UrlRewriteRulesDescriptor descriptor, Writer writer,
boolean omitXmlHeader ) throws IOException {
Review comment:
No, because of this class implements `UrlRewriteRulesExporter`. As of now,
only one implementation exists, but the general contract - defined by the
interface - that you store something and return it (e.g. Document in case of
XML, String in case of JSON).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
