risdenk commented on a change in pull request #164: KNOX-2053 - New REST API to
create/read/update/delete service definitions
URL: https://github.com/apache/knox/pull/164#discussion_r334954992
##########
File path: gateway-server/pom.xml
##########
@@ -135,6 +142,11 @@
<artifactId>javax.servlet-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
Review comment:
Guava is a really ugly dependency to pull in. Historically it broke
backwards dependencies. It also conflicts with most of the Hadoop components
versions of guava. For example Hadoop and Hive both use a VERY old version of
Guava. Once a dependency is pulled in, it is very hard to get rid of it.
We should try our hardest to not include it if possible. Most Guava stuff is
in JDK 8 now so don't need the extra dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
