smolnar82 commented on a change in pull request #165: KNOX-2057 - Using unique
table IDs through different test cases even if they are in different test
classes (JVM is shared in during parallel execution)
URL: https://github.com/apache/knox/pull/165#discussion_r335146404
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/KnoxShellTable.java
##########
@@ -113,7 +112,7 @@ public long getId() {
}
public static KnoxShellTableBuilder builder() {
- return new KnoxShellTableBuilder(getUniqueTableId());
+ return new KnoxShellTableBuilder();
}
static long getUniqueTableId() {
Review comment:
What do you mean by `doesn't need to be accessible`? The `builder` method?
That must be `public`; that is the entry point...one usually builds a table
like this:
`locations =
KnoxShellTable.builder().jdbc().driver("org.apache.derby.jdbc.EmbeddedDriver").connectTo("jdbc:derby:/Users/smolnar/test/derbyDb").sql("SELECT
* FROM sample.locations where zip < 10")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
