[ 
https://issues.apache.org/jira/browse/KNOX-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967594#comment-16967594
 ] 

ASF subversion and git services commented on KNOX-1842:
-------------------------------------------------------

Commit d9a3eb9307e91ef1b40d72fed9f22511fe4b1646 in knox's branch 
refs/heads/master from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=d9a3eb9 ]

KNOX-1842 - Upgrade httpclient to 4.5.10 (#176)

HttpClient 4.5.7 broke url normalization. Knox
didn't have any tests for this case and so we
had to revert after the fact. HttpClient 4.5.8
fixed a lot of the url normalization and some
libraries decided to turn url normalization off.

This commit does the following:
* Adds a test for %2F - KNOX-1005
    * This test passes under HttpClient 4.5.6 and 4.5.8+
    * It breaks as expected under HttpClient 4.5.7
* Adds an explicit config enabling url normalization
    * Ensures that we are in control of url normalization
    * Adds a test for this configuration as well
* Test with both HttpClient normalization enabled and disabled
    * `rest-assured` doesn't expose `RequestConfig` to disable
url normalization
    * Shows how to use HttpClient in `GatewayBasicFuncTest`

All the url safe characters like %2F are fixed by HTTPCLIENT-1968.

The case of `/abc///def` is normalized to `/abc/def` the same
way that Knox does internally with `getPathInfo` and Java URI.

Signed-off-by: Kevin Risden <kris...@apache.org>

> Upgrade httpclient to 4.5.10
> ----------------------------
>
>                 Key: KNOX-1842
>                 URL: https://issues.apache.org/jira/browse/KNOX-1842
>             Project: Apache Knox
>          Issue Type: Sub-task
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Minor
>             Fix For: 1.4.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Upgrade httpclient 4.5.6 to 4.5.10



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to