[
https://issues.apache.org/jira/browse/KNOX-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967859#comment-16967859
]
James Chen edited comment on KNOX-2095 at 11/5/19 10:50 PM:
------------------------------------------------------------
Hi Kevin,
Sorry for the delay; for some reason I had thought the patch was for v1.2.0 and
had been testing it against that. Currently, ant verify fails locally against
Knox 1.4.0 when the patch is applied, but the master branch also locally fails
on the same test so it's likely a transient error.
I believe you mentioned that you had some comments to make, so I've
preemptively set up a PR at [https://github.com/apache/knox/pull/177]. I'll
update this post once ant verify succeeds.
EDIT: Both master and KNOX-2095 succeeded; the PR builds.
Best regards,
-James
was (Author: jamchen):
Hi Kevin,
Sorry for the delay; for some reason I had thought the patch was for v1.2.0 and
had been testing it against that. Currently, ant verify fails locally against
Knox 1.4.0 when the patch is applied, but the master branch also locally fails
on the same test so it's likely a transient error.
I believe you mentioned that you had some comments to make, so I've
preemptively set up a PR at https://github.com/apache/knox/pull/177. I'll
update this post once ant verify succeeds.
Best regards,
-James
> Many errors (E.G. 504s) being masked as 500 errors
> --------------------------------------------------
>
> Key: KNOX-2095
> URL: https://issues.apache.org/jira/browse/KNOX-2095
> Project: Apache Knox
> Issue Type: Improvement
> Affects Versions: 1.2.0, 1.3.0
> Reporter: James Chen
> Assignee: James Chen
> Priority: Minor
> Labels: easyfix
> Fix For: 1.4.0
>
> Attachments: KNOX-2095.patch, jamchen504patch.patch
>
> Original Estimate: 168h
> Time Spent: 10m
> Remaining Estimate: 167h 50m
>
> When errors occur while accessing the Knox gateway, errors are forcibly
> overridden and represented as 500 errors, rather than whatever errors they
> should be.
> For example, when the timeout value under gateway.httpclient.socketTimeout is
> set to a very low timeout value (E.G. 1 ms) under gateway-site.xml, a socket
> timeout exception is produced by the getHttpClient().execute(
> outboundRequest) call. However, this is caught by the surrounding try-catch
> block and thrown again as an IOException. This results in a generic 500
> error, rather than a 504 error one would normally expect from this sort of
> interaction.
>
> For these sorts of scenarios, I believe it would be prudent to create a dummy
> HttpResponse using a HttpResponseFactory object for the inboundResponse with
> the corresponding error code (E.G. HttpStatus.SC_GATEWAY_TIMEOUT in the event
> of a SocketTimeoutException) and return that instead to trigger the
> appropriate 504 error. I suspect there are other sorts of potential error
> code triggers that get this same IOException treatment that would be better
> off receiving their own error codes.
>
> Judging from the source code, this issue likely affects version 1.3.0, though
> this has not been tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
