[
https://issues.apache.org/jira/browse/KNOX-2071?focusedWorklogId=339451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339451
]
ASF GitHub Bot logged work on KNOX-2071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 16:13
Start Date: 06/Nov/19 16:13
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #178: KNOX-2071 -
Configurable maximum token lifetime for TokenStateService
URL: https://github.com/apache/knox/pull/178#discussion_r343186849
##########
File path:
gateway-service-knoxtoken/src/test/java/org/apache/knox/gateway/service/knoxtoken/TokenServiceResourceTest.java
##########
@@ -23,6 +23,7 @@
import com.nimbusds.jose.JWSVerifier;
import com.nimbusds.jose.crypto.RSASSASigner;
import com.nimbusds.jose.crypto.RSASSAVerifier;
+import org.apache.commons.lang3.tuple.Pair;
Review comment:
Right but would be better to get rid of it in other modules instead of just
using that as an argument to keep adding it. Once it is added as a test module
that opens it up to other usages. The only way to prevent usage is to make sure
its not included in the pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339451)
Time Spent: 1h 20m (was: 1h 10m)
> Configurable maximum token lifetime for TokenStateService
> ---------------------------------------------------------
>
> Key: KNOX-2071
> URL: https://issues.apache.org/jira/browse/KNOX-2071
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Minor
> Fix For: 1.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> With KNOX-2067, and the ability to renew tokens up to a maximum token
> lifetime, it should be possible to configure this maximum lifetime as either
> a gateway-level configuration item, or as a service param of a deployed
> instance of a token issuing service (e.g., KnoxToken service).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
