goelrajat opened a new pull request #200: KNOX-2004: Adding changes for 
handling Ping/Pong message from backend…
URL: https://github.com/apache/knox/pull/200
 
 
   … server on websocket connection
   
   (It is very **important** that you created an Apache Knox JIRA for this 
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
   
   ## What changes were proposed in this pull request?
   
   Changes add a new message handler for handling Ping/Pong messages from 
backend websocket server and relay the same to Frontend. Ping/Pong messages are 
control messages to keep websocket connection alive.
   
   ## How was this patch tested?
   
   Changes were tested on a local test setup to check if websocket was indeed 
kept alive and it was working. In absence of these changes, any Ping messages 
received from backend server, were being responded by lower jetty server layer 
and were propagated to front end. Because of this, Frontend connection was 
getting timed out. With these changes, timeouts were not seen.
   I have also a added a Unit Test for the same.
   
   Please review [Knox Contributing 
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
 before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to