[
https://issues.apache.org/jira/browse/KNOX-2134?focusedWorklogId=348323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348323
]
ASF GitHub Bot logged work on KNOX-2134:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 19:42
Start Date: 22/Nov/19 19:42
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #205: KNOX-2134 -
Add caching to ZookeeperRemoteAliasService
URL: https://github.com/apache/knox/pull/205#discussion_r349764017
##########
File path:
gateway-server/src/test/java/org/apache/knox/gateway/services/security/impl/ZookeeperRemoteAliasMonitorTest.java
##########
@@ -234,13 +233,19 @@ public void testListener() throws Exception {
+ ZookeeperRemoteAliasService.PATH_SEPARATOR +
expectedAliasDev,
zkAlias.encrypt(expectedPasswordDev).getBytes(StandardCharsets.UTF_8));
+ try {
+ Thread.sleep(1000);
Review comment:
It takes some time for the znode changes to propagate to the listener. Back
when I had done the original remote registry work, I had used much shorter
delay intervals in the tests, but then the tests would intermittently fail. The
delay in those tests was bumped to 1s, so I've done the same here, to avoid the
same intermittent failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 348323)
Time Spent: 1h 10m (was: 1h)
> Add caching to ZookeeperRemoteAliasService
> ------------------------------------------
>
> Key: KNOX-2134
> URL: https://issues.apache.org/jira/browse/KNOX-2134
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The ZookeeperRemoteAliasService implementation always goes to ZooKeeper to
> retrieve alias data. Instead, it should cache the data locally to make
> password retrieval much faster.
> The implementation already receives pushes from ZooKeeper when alias znodes
> change, so instead of only updating the associated local alias service, it
> can also update its own cache.
> This way, it only ever needs to go to ZooKeeper for add/remove operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
