[ https://issues.apache.org/jira/browse/KNOX-1742?focusedWorklogId=374772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-374772 ]
ASF GitHub Bot logged work on KNOX-1742: ---------------------------------------- Author: ASF GitHub Bot Created on: 21/Jan/20 01:42 Start Date: 21/Jan/20 01:42 Worklog Time Spent: 10m Work Description: risdenk commented on pull request #241: KNOX-1742 - Simple SQL Client in KnoxShell for access to JDBC sources URL: https://github.com/apache/knox/pull/241#discussion_r368777946 ########## File path: build-tools/src/main/resources/build-tools/pmd/pmd-ruleset.xml ########## @@ -88,6 +88,7 @@ limitations under the License. <rule ref="category/java/multithreading.xml"> <exclude name="AvoidSynchronizedAtMethodLevel" /> <exclude name="UseConcurrentHashMap" /> + <exclude name="DoNotUseThreads" /> Review comment: Don't do this. There is a way to ignore specific methods only. We really shouldn't be creating threads especially in Jetty. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 374772) Time Spent: 20m (was: 10m) > Simple SQL Client in KnoxShell for access to JDBC datasources > ------------------------------------------------------------- > > Key: KNOX-1742 > URL: https://issues.apache.org/jira/browse/KNOX-1742 > Project: Apache Knox > Issue Type: Improvement > Components: KnoxShell > Reporter: Larry McCay > Assignee: Larry McCay > Priority: Major > Fix For: 1.5.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Let's take the following wiki article example and make it an actual feature > of KnoxShell: > https://cwiki.apache.org/confluence/display/KNOX/SQL+Client+Example+using+KnoxShell+in+Apache+Knox > In order to make it a generic feature, we will need to do a number of things: > # add a lib directory > # add the HiveDriver - *maybe* - perhaps it is better to have the user > download the right version? > # add commons-logging jar to lib directory > # add a real table rendering class to the KnoxShell rather than embedded in > the SQL client script - so that other features and scripts can use it to > render results > # add the knoxline.sh and hive2.groovy script to bin directory -- This message was sent by Atlassian Jira (v8.3.4#803005)