risdenk commented on a change in pull request #241: KNOX-1742 - Simple SQL
Client in KnoxShell for access to JDBC sources
URL: https://github.com/apache/knox/pull/241#discussion_r369100671
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/KnoxSession.java
##########
@@ -593,7 +593,26 @@ public String toString() {
String s = JsonUtils.renderAsJsonString(map);
String home = System.getProperty("user.home");
try {
- write(new File(home + File.separator + ".knoxshell" + File.separator +
fileName), s);
+ write(new File(
+ home + File.separator + ".knoxshell" + File.separator + fileName),
s);
Review comment:
Just a note for future reference:
This could be `Paths.get(home, ".knoxshell", fileName).toFile()` or just use
the `Path` directly instead of manually constructing a path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
