smolnar82 opened a new pull request #248: KNOX-2206 - Log exclusion of a discovered service due to configuration issues URL: https://github.com/apache/knox/pull/248 # What changes were proposed in this pull request? Adding a `WARN` level log in case there is a configuration issue with the discovered service role. ## How was this patch tested? JUnit tests: ``` mvn clean -Dshellcheck=true -T1C verify -Prelease,package ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 19:14 min (Wall Clock) [INFO] Finished at: 2020-01-30T09:38:40+01:00 [INFO] Final Memory: 421M/2282M [INFO] ------------------------------------------------------------------------ ``` Additionally, I executed the following manual test steps: 1. built, deployed and started Knox with may changes 2. produced a shared-provider and descriptor with proper CM discovery settings pointing to my test cluster 3. made sure that `HIVE/HIVESERVER2` did not have a config called `hive.server2.transport.mode` `impalad_enable_webserver` was set to `true` for `IMPALA/IMPALAD` (this is the expected config) `dfs_webhdfs_enabled` was set to `true` for `HDFS/NAMENODE` (this is the expected config) `hive_server2_transport_mode` was set to `binary` for `HIVE_ON_TEZ/HIVESERVER2` 8. touched the descriptor file to trigger a topology re-generation Relevant logs: ``` 2020-01-30 09:15:36,180 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(180)) - Discovered service: HDFS-1 (HDFS) 2020-01-30 09:15:37,410 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HDFS-1-BALANCER-865a1c62c5bd7804fab20cae3eddca4f (BALANCER) 2020-01-30 09:15:37,716 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HDFS-1-DATANODE-d29bba6543c47ca01e7d90c1b76a60b3 (DATANODE) 2020-01-30 09:15:38,034 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HDFS-1-NAMENODE-865a1c62c5bd7804fab20cae3eddca4f (NAMENODE) 2020-01-30 09:15:38,522 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HDFS-NFSGATEWAY-1 (NFSGATEWAY) 2020-01-30 09:15:38,852 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HDFS-GATEWAY-1 (GATEWAY) 2020-01-30 09:15:39,150 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HDFS-1-SECONDARYNAMENODE-865a1c62c5bd7804fab20cae3eddca4f (SECONDARYNAMENODE) 2020-01-30 09:15:39,466 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HDFS-1-DATANODE-4f16be5c7d9e2ec9d96015b92d4115f4 (DATANODE) ... 2020-01-30 09:15:44,407 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(180)) - Discovered service: HIVE-1 (HIVE) 2020-01-30 09:15:45,397 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HIVE-1-GATEWAY-d29bba6543c47ca01e7d90c1b76a60b3 (GATEWAY) 2020-01-30 09:15:45,705 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HIVE-1-GATEWAY-865a1c62c5bd7804fab20cae3eddca4f (GATEWAY) 2020-01-30 09:15:46,012 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HIVE-1-HIVEMETASTORE-865a1c62c5bd7804fab20cae3eddca4f (HIVEMETASTORE) 2020-01-30 09:15:46,330 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HIVE-1-HIVESERVER2-d29bba6543c47ca01e7d90c1b76a60b3 (HIVESERVER2) 2020-01-30 09:15:46,865 WARN discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(199)) - Service role HIVE-1-HIVESERVER2-d29bba6543c47ca01e7d90c1b76a60b3 has configuration issues: Missing configuration: hive.server2.transport.mode ... 2020-01-30 09:15:58,150 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(180)) - Discovered service: IMPALA-1 (IMPALA) 2020-01-30 09:15:58,938 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: IMPALA-1-IMPALAD-4f16be5c7d9e2ec9d96015b92d4115f4 (IMPALAD) 2020-01-30 09:16:36,950 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: IMPALA-1-CATALOGSERVER-865a1c62c5bd7804fab20cae3eddca4f (CATALOGSERVER) 2020-01-30 09:16:46,045 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: IMPALA-1-STATESTORE-865a1c62c5bd7804fab20cae3eddca4f (STATESTORE) 2020-01-30 09:16:53,094 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: IMPALA-1-IMPALAD-d29bba6543c47ca01e7d90c1b76a60b3 (IMPALAD) ... 2020-01-30 09:17:18,173 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(180)) - Discovered service: HIVE_ON_TEZ-1 (HIVE_ON_TEZ) 2020-01-30 09:17:18,927 INFO discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(187)) - Discovered service role: HIVE_ON_TEZ-1-HIVESERVER2-865a1c62c5bd7804fab20cae3eddca4f (HIVESERVER2) 2020-01-30 09:17:19,890 WARN discovery.cm (ClouderaManagerServiceDiscovery.java:discoverCluster(199)) - Service role HIVE_ON_TEZ-1-HIVESERVER2-865a1c62c5bd7804fab20cae3eddca4f has configuration issues: Invalid configuration: hive_server2_transport_mode. Expected=http; Found=binary ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
