[
https://issues.apache.org/jira/browse/KNOX-2206?focusedWorklogId=379312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379312
]
ASF GitHub Bot logged work on KNOX-2206:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/20 10:53
Start Date: 30/Jan/20 10:53
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #248: KNOX-2206 - Log
exclusion of a discovered service due to configuration issues
URL: https://github.com/apache/knox/pull/248#discussion_r372880668
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ServiceModelGeneratorHandleResponse.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.knox.gateway.topology.discovery.cm;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+
+public class ServiceModelGeneratorHandleResponse {
+ private final Collection<String> configurationIssues = new HashSet<>();
+ private boolean handles;
+
+ public ServiceModelGeneratorHandleResponse(boolean handles) {
+ this.handles = handles;
+ }
+
+ public boolean isHandles() {
Review comment:
`isHandles` grammatically sounds wrong. `wasHandled` or something along
those lines. Maybe hasError?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379312)
Time Spent: 20m (was: 10m)
> Cloudera Manager - Service Discovery - log exclusion of a service due to
> configuration issues
> ---------------------------------------------------------------------------------------------
>
> Key: KNOX-2206
> URL: https://issues.apache.org/jira/browse/KNOX-2206
> Project: Apache Knox
> Issue Type: New Feature
> Components: cm-discovery
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If a service does not get discovered due to a missing/wrong configuration
> there is no any trace to find out if that happened. At a minimum, a WARN
> level message should be added in the logs saying something similar to
> 'service X is excluded because configuration Y does not exists or incorrect'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
