[
https://issues.apache.org/jira/browse/KNOX-2238?focusedWorklogId=389445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389445
]
ASF GitHub Bot logged work on KNOX-2238:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/20 13:38
Start Date: 19/Feb/20 13:38
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #267: KNOX-2238 CM
discovery - Add TLS support to Phoenix auto discovery
URL: https://github.com/apache/knox/pull/267#discussion_r381292926
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/phoenix/PhoenixServiceModelGenerator.java
##########
@@ -58,14 +59,24 @@ public ServiceModel generateService(ApiService
service,
ApiServiceConfig serviceConfig,
ApiRole role,
ApiConfigList roleConfig) {
+
String hostname = role.getHostRef().getHostname();
- // Phoenix Query Server does not support https
+ String sslEnabledRaw = getRoleConfigValue(roleConfig, SSL_ENABLED);
Review comment:
This can be simplified. No need to store `sslEnabledRaw`. just do something
like:
```
if (Boolean.parseBoolean(getRoleConfigValue(roleConfig, SSL_ENABLED))) {
scheme = "https";
}
```
`Boolean.parseBoolean` will handle null correctly and return false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389445)
Time Spent: 20m (was: 10m)
> CM discovery - Add TLS support to Phoenix auto discovery
> --------------------------------------------------------
>
> Key: KNOX-2238
> URL: https://issues.apache.org/jira/browse/KNOX-2238
> Project: Apache Knox
> Issue Type: Improvement
> Components: cm-discovery
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> TLS support has been added to Phoenix Query Server, and it is also supported
> in Cloudera Manager for Phoenix Query Server now.
> Add TLS detection to Phoenix Auto Discovery.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
