smolnar82 commented on a change in pull request #297: KNOX-2301 and KNOX-2302
URL: https://github.com/apache/knox/pull/297#discussion_r396338380
##########
File path:
gateway-spi/src/main/java/org/apache/knox/gateway/topology/Provider.java
##########
@@ -82,4 +84,41 @@ public void setRole( String role ) {
this.role = role;
}
+ @Override
+ public int hashCode() {
+ return new HashCodeBuilder().append(name)
+ .append(role)
+ .append(params)
+ .append(enabled)
+ .build();
+ }
+
+ @Override
+ public boolean equals(Object obj) {
Review comment:
I really like you are using `HashCodeBuilder` above. Why not use
`EqualsBuilder` here (this would require to implement `hashCode` and `equals`
in `Provider` too)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
