moresandeep commented on a change in pull request #304: KNOX-2315 - Fix
zookeeper Kerberos Auth
URL: https://github.com/apache/knox/pull/304#discussion_r404111034
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/ZookeeperRemoteAliasService.java
##########
@@ -127,9 +156,18 @@ private static void ensureEntry(final String path, final
RemoteConfigurationRegi
// content may not be trustworthy.
if (remoteClient.isAuthenticationConfigured()) {
LOG.correctingSuspectWritableRemoteConfigurationEntry(path);
-
// Replace the existing ACL with one that permits only
authenticated users
- remoteClient.setACL(path,
Collections.singletonList(AUTHENTICATED_USERS_ALL));
+ if (remoteClient.authenticationType()
Review comment:
` LocalFileSystemRemoteConfigurationRegistryClientService` is used only for
testing, that is why it returns null, but it is better to defend agains NPEs,
will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
