lmccay commented on a change in pull request #307: KNOX-2304 - CM discovery
cluster config monitor needs to be aware of …
URL: https://github.com/apache/knox/pull/307#discussion_r405572741
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/monitor/PollingConfigurationAnalyzer.java
##########
@@ -365,12 +375,32 @@ private DiscoveryApiClient getApiClient(final
ServiceDiscoveryConfig discoveryCo
clusterName,
lastTimestamp);
for (ApiEvent event : events) {
- restartEvents.add(new RestartEvent(event));
+ List<ApiEventAttribute> attributes = event.getAttributes();
+ Map<String,Object> map = getAttributeMap(attributes);
Review comment:
That is what I had before and it is much more complicated as I wanted to
avoid creating a map. Note that we are checking two correlated attributes. The
command issued and its status. Since you don't know what order they are in you
have to squirrel them away then check whether you have both then add. If we end
up having to add more events that would be even messier to do. Now, we can get
the map upfront and do whatever processing of it afterward much more cleanly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
