pzampino commented on a change in pull request #337:
URL: https://github.com/apache/knox/pull/337#discussion_r434053333



##########
File path: 
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultKeystoreService.java
##########
@@ -357,6 +359,30 @@ public void removeCredentialForCluster(String clusterName, 
String alias) throws
     }
   }
 
+  @Override
+  public void removeCredentialsForCluster(String clusterName, Set<String> 
aliases) throws KeystoreServiceException {
+    synchronized (this) {
+      KeyStore ks = getCredentialStoreForCluster(clusterName);
+      if (ks != null) {
+        try {
+          // Delete all the entries
+          for (String alias : aliases) {
+            if (ks.containsAlias(alias)) {
+              ks.deleteEntry(alias);
+            }
+            removeFromCache(clusterName, alias);

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to