smolnar82 commented on a change in pull request #348: URL: https://github.com/apache/knox/pull/348#discussion_r442453649
########## File path: gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/config/AzureADClientConfigurationDecorator.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.knox.gateway.pac4j.config; + +import java.util.List; +import java.util.Map; + +import org.pac4j.core.client.Client; +import org.pac4j.core.http.callback.PathParameterCallbackUrlResolver; +import org.pac4j.oidc.client.AzureAdClient; + +public class AzureADClientConfigurationDecorator implements ClientConfigurationDecorator { + private static final String AZURE_AD_CLIENT_CLASS_NAME = AzureAdClient.class.getSimpleName(); + + @Override + public void decorateClients(List<Client> clients, Map<String, String> properties) { + for (Client client : clients) { + if (AZURE_AD_CLIENT_CLASS_NAME.equalsIgnoreCase(client.getName())) { + // special handling for Azure AD, use path separators instead of query params + ((AzureAdClient) client).setCallbackUrlResolver(new PathParameterCallbackUrlResolver()); Review comment: At this point, an instance of `AzureADClient` has already been built by `org.pac4j.config.builder.OidcClientBuilder` using the same properties object. While decorating the callback URL resolver we do not need to check those properties because setting it to an instance of `PathParameterCallbackUrlResolver` has no any dependency on any property. P.S: this piece of code was just re-factored out from `org.apache.knox.gateway.pac4j.filter.Pac4jDispatcherFilter` (as it fits into the decorator pattern) I did not change the "logic". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
