pzampino commented on a change in pull request #358:
URL: https://github.com/apache/knox/pull/358#discussion_r451717422
##########
File path: gateway-release/home/conf/gateway-site.xml
##########
@@ -18,6 +18,11 @@ limitations under the License.
-->
<configuration>
+ <property>
+ <name>gateway.services</name>
Review comment:
I am strongly in favor of your suggestion. I believe it's a more
flexible pattern than list-value properties. My examples had originally
included `gateway.service.$SERVICE.impl` as property names, but I modified them
for simplicity, since it was only an example, and not the primary point of my
comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
