[ https://issues.apache.org/jira/browse/KNOX-2399?focusedWorklogId=458675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458675 ]
ASF GitHub Bot logged work on KNOX-2399: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Jul/20 14:33 Start Date: 14/Jul/20 14:33 Worklog Time Spent: 10m Work Description: pzampino commented on a change in pull request #361: URL: https://github.com/apache/knox/pull/361#discussion_r454401688 ########## File path: gateway-server/src/test/java/org/apache/knox/gateway/services/factory/ServiceFactoryTest.java ########## @@ -52,7 +52,7 @@ protected final GatewayServices gatewayServices = EasyMock.createNiceMock(GatewayServices.class); protected final GatewayConfig gatewayConfig = EasyMock.createNiceMock(GatewayConfig.class); - protected final Map<String, String> options = Collections.emptyMap(); + protected final Map<String, String> options = new HashMap<>(); Review comment: Does the mutability of the map matter for a _test_? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 458675) Time Spent: 2h 10m (was: 2h) > Implement ZK token state service > -------------------------------- > > Key: KNOX-2399 > URL: https://issues.apache.org/jira/browse/KNOX-2399 > Project: Apache Knox > Issue Type: Task > Affects Versions: 1.4.0 > Reporter: Sandor Molnar > Assignee: Sandor Molnar > Priority: Major > Fix For: 1.5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Implement a new {{TokenStateService}} implementation which stores/fetches > token related metadata in Zookeeper. The new service should be configurable > to directly go to Zookeeper or use some local cache (e.g. a local alias > service). -- This message was sent by Atlassian Jira (v8.3.4#803005)