[
https://issues.apache.org/jira/browse/KNOX-2575?focusedWorklogId=586060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586060
]
ASF GitHub Bot logged work on KNOX-2575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 18:13
Start Date: 20/Apr/21 18:13
Worklog Time Spent: 10m
Work Description: moresandeep commented on a change in pull request #436:
URL: https://github.com/apache/knox/pull/436#discussion_r616929437
##########
File path:
gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java
##########
@@ -80,12 +82,17 @@ public JWTToken(String alg, String[] claimsArray,
List<String> audiences, boolea
if(claimsArray[3] != null) {
builder = builder.expirationTime(new
Date(Long.parseLong(claimsArray[3])));
}
+ if(claimsArray[4] != null) {
Review comment:
Here I just log and move on, since we are dealing with arrays of fix
size initialized earlier in a different class there is no easy way to recover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586060)
Time Spent: 1h (was: 50m)
> Add `kid` and `jku` claims to JWT tokens issues by Knox
> -------------------------------------------------------
>
> Key: KNOX-2575
> URL: https://issues.apache.org/jira/browse/KNOX-2575
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> With support for JWKS endpoint out of the way (KNOX-2570) JWT tokens issued
> by Knox should include `kid` and `jku` claims.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
