[ 
https://issues.apache.org/jira/browse/KNOX-2603?focusedWorklogId=597695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597695
 ]

ASF GitHub Bot logged work on KNOX-2603:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/May/21 14:31
            Start Date: 17/May/21 14:31
    Worklog Time Spent: 10m 
      Work Description: pzampino commented on a change in pull request #448:
URL: https://github.com/apache/knox/pull/448#discussion_r633584139



##########
File path: 
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java
##########
@@ -30,8 +30,8 @@
  */
 public class SignatureVerificationCache {
 
-    public static final String JWT_VERIFIED_CACHE_MAX = 
"jwt.verified.cache.max";
-    public static final int    JWT_VERIFIED_CACHE_MAX_DEFAULT = 250;
+    public static final String VERIFIED_TOKENS_CACHE_MAX = 
"verified.tokens.cache.max";

Review comment:
       Other similar properties begin with the context (e.g., jwt, sso, 
etc...), so it seems appropriate to begin with the context (i.e., tokens) with 
this one also.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 597695)
    Time Spent: 40m  (was: 0.5h)

> Passcode token verification event should be cached
> --------------------------------------------------
>
>                 Key: KNOX-2603
>                 URL: https://issues.apache.org/jira/browse/KNOX-2603
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 1.6.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Similar to JWT token verifications, Passcode token verifications should also 
> be cached so that we could save expensive MAC generation for already verified 
> tokens.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to