[
https://issues.apache.org/jira/browse/KNOX-2628?focusedWorklogId=621397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621397
]
ASF GitHub Bot logged work on KNOX-2628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/21 20:41
Start Date: 11/Jul/21 20:41
Worklog Time Spent: 10m
Work Description: smolnar82 edited a comment on pull request #462:
URL: https://github.com/apache/knox/pull/462#issuecomment-877857475
> What about a test?
Thanks for your review, @pzampino !
I modified
`AliasBasedTokenStateServiceTest.testAddAndRemoveTokenIncludesCache()` to match
the exact alias name list at removal time (instead of `anyObject`), so that we
can make sure the appropriate alias removals happen.
In addition to this, I added code to make sure that information is moved
from the in-memory cache too.
Since you already approved, let me wait for a green build and merge this
change.
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621397)
Time Spent: 1h (was: 50m)
> AliasBasedTokenStateService does not revoke all aliases
> -------------------------------------------------------
>
> Key: KNOX-2628
> URL: https://issues.apache.org/jira/browse/KNOX-2628
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Critical
> Time Spent: 1h
> Remaining Estimate: 0h
>
> While testing KNOX-2624 with {{AliasBasedTokenStateService}} I figured that
> removing (revoking) a token ended up removing the 'token' and 'token-max'
> aliases but the 'token-iss' and 'token-meta' aliases remained in the
> credential store.
>
> Steps to reproduce:
> * start the Knox Gateway w/o changing gateway-site.xml
> * generate a token on the {{tokengen}} UI
> * revoke that token on the token management UI
> * list the keystore content:
> {{keytool -list -keystore data/security/keystores/__gateway-credentials.jceks
> -storetype jceks -storepass ***}}
> {noformat}
> 81d9337d-ac69-427f-aefc-fb668784763e--iss, Jul 9, 2021, SecretKeyEntry,
> 81d9337d-ac69-427f-aefc-fb668784763e--meta, Jul 9, 2021, SecretKeyEntry,
> knox.token.hash.key, Jul 8, 2021, SecretKeyEntry, {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
