[
https://issues.apache.org/jira/browse/KNOX-2629?focusedWorklogId=622175&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622175
]
ASF GitHub Bot logged work on KNOX-2629:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/21 19:25
Start Date: 13/Jul/21 19:25
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #465:
URL: https://github.com/apache/knox/pull/465#issuecomment-879341321
I tried it locally (intentionally made a mistake in `knox-functions.sh`) and
it worked like a charm:
```
[WARNING] No shellcheck download url provided for current os.name-os.arch
[Mac_OS_X-x86_64]
[INFO] shellcheck release will be fetched at
[https://github.com/koalaman/shellcheck/releases/download/v0.7.2/shellcheck-v0.7.2.darwin.x86_64.tar.xz]
[WARNING] No signatures were supplied, skipping file validation
[INFO] Got from cache:
/Users/sandormolnar/.m2/repository/.cache/download-maven-plugin/shellcheck-v0.7.2.darwin.x86_64.tar.xz_039c1f418e8c8ff4a7ca3beddcbfc3dc
[INFO] Expanding:
/Users/sandormolnar/projects/knox/gateway-release-common/target/shellcheck-plugin/shellcheck-v0.7.2.darwin.x86_64.tar.xz
into
/Users/sandormolnar/projects/knox/gateway-release-common/target/shellcheck-plugin
[WARNING]
[WARNING] In
/Users/sandormolnar/projects/knox/gateway-release-common/home/bin/knox-functions.sh
line 57:
[WARNING] if [ "$JAVA" != "" ]; then;
[WARNING] ^-- SC1051: Semicolons directly after
'then' are not allowed. Just remove it.
[WARNING]
[WARNING] For more information:
[WARNING] https://www.shellcheck.net/wiki/SC1051 -- Semicolons directly
after 'then' ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 622175)
Time Spent: 50m (was: 40m)
> Fix new shellcheck errors
> --------------------------
>
> Key: KNOX-2629
> URL: https://issues.apache.org/jira/browse/KNOX-2629
> Project: Apache Knox
> Issue Type: Task
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> With shellcheck v0.7.2 lots of new errors are coming such as:
> {code:java}
> In gateway-release-common/home/bin/knox-functions.sh line 25:
> APP_HOME_DIR=$(dirname "$APP_BIN_DIR")
> ^----------^ SC2153: Possible misspelling:
> APP_BIN_DIR may not be assigned, but APP_PID_DIR is.For more information:
> https://www.shellcheck.net/wiki/SC2153 -- Possible misspelling:
> APP_BIN_DIR...{code}
> {code:java}
> In ./gateway-shell-release/home/bin/knoxshell.sh line 30:
> . "$APP_BIN_DIR"/knox-functions.sh
> ^-- SC1091: Not following: ./knox-functions.sh: openBinaryFile: does not
> exist (No such file or directory) {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
