pzampino commented on a change in pull request #484:
URL: https://github.com/apache/knox/pull/484#discussion_r694971191
##########
File path:
gateway-service-knoxtoken/src/test/java/org/apache/knox/gateway/service/knoxtoken/TokenServiceResourceTest.java
##########
@@ -986,6 +986,30 @@ public void testUnlimitedTokensPerUser() throws Exception {
testLimitingTokensPerUser(String.valueOf("-1"), 100);
}
+ @Test
+ public void testTokenLimitChangeAfterAlreadyHavingTokens() throws Exception {
+ Map<String, String> contextExpectations = new HashMap<>();
+ contextExpectations.put(KNOX_TOKEN_USER_LIMIT, "-1");
+ configureCommonExpectations(contextExpectations, Boolean.TRUE);
+ TokenResource tr = new TokenResource();
+ tr.request = request;
+ tr.context = context;
+ tr.init();
+ // already have N tokens
+ int numberOfPreExistingTokens = 5;
+ for (int i = 0; i < numberOfPreExistingTokens; i++) {
+ tr.doGet();
+ }
+ Response getKnoxTokensResponse = tr.getUserTokens(USER_NAME);
+ Collection<String> tokens = ((Map<String, Collection<String>>)
JsonUtils.getObjectFromJsonString(getKnoxTokensResponse.getEntity().toString()))
+ .get("tokens");
+ assertEquals(tokens.size(), numberOfPreExistingTokens);
+ // change the limit and try generate one more
+ tr.setTokenLimitPerUser(numberOfPreExistingTokens -1);
+ Response response = tr.doGet();
+ assertTrue(response.getEntity().toString().contains("Unable to get token -
token limit exceeded."));
+ }
+
@Test
public void tesTokenLimitPerUserExceeded() throws Exception {
Review comment:
Could you also correct this test name to
tes**t**TokenLimitPerUserExceeded ?
##########
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##########
@@ -741,4 +741,7 @@ private String safeGetMessage(Throwable t) {
return message != null ? message : "null";
}
+ void setTokenLimitPerUser(int tokenLimitPerUser) { // visible for testing
Review comment:
You could also use reflection in the test to set this, rather than
adding a method ONLY for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
