zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707219943
##########
File path:
gateway-provider-rewrite/src/test/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteRulesDescriptorFactoryTest.java
##########
@@ -98,10 +99,10 @@ public void testLoadMissingFile() throws IOException {
@Test
public void testLoadEmptyFile() {
- Logger logger = org.apache.log4j.LogManager.getLogger(
"org.apache.commons.digester3.Digester" );
+ Logger logger = (Logger)LogManager.getLogger(
"org.apache.commons.digester3.Digester" );
Review comment:
There is no setLevel/setAdditivity method in
`org.apache.logging.log4j.Logger`, only in
`org.apache.logging.log4j.core.Logger`.
This is how the the Log4j's compatibility API does this as well:
https://github.com/apache/logging-log4j2/blob/f630e16ecf196b5a7097a224a7997801b819ddd0/log4j-1.2-api/src/main/java/org/apache/log4j/legacy/core/CategoryUtil.java#L60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
