[
https://issues.apache.org/jira/browse/KNOX-2661?focusedWorklogId=650468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650468
]
ASF GitHub Bot logged work on KNOX-2661:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/21 09:53
Start Date: 14/Sep/21 09:53
Worklog Time Spent: 10m
Work Description: smolnar82 opened a new pull request #494:
URL: https://github.com/apache/knox/pull/494
## What changes were proposed in this pull request?
There were some public API endpoints in `TokenResource` with wrong HTTP
methods. I changed hem and now the resource looks like this:
- GET - `/knoxtoken/api/v1/token`
- GET - `/knoxtoken/api/v1/token/getUserTokens`
- GET - `/knoxtoken/api/v1/token/getTssStatus`
- POST - `/knoxtoken/api/v1/token`
- PUT - `/knoxtoken/api/v1/token/renew`
- PUT - `/knoxtoken/api/v1/token/enable`
- PUT - `/knoxtoken/api/v1/token/disable`
- DELETE - `/knoxtoken/api/v1/token/revoke`
## How was this patch tested?
Ran manual test steps (including token management UI operations and `curl`
requests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 650468)
Remaining Estimate: 0h
Time Spent: 10m
> Consolidate HTTP methods in TokenResource
> -----------------------------------------
>
> Key: KNOX-2661
> URL: https://issues.apache.org/jira/browse/KNOX-2661
> Project: Apache Knox
> Issue Type: Task
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the new token management UI creation, the enable/disable methods
> changed from POST to PUT. However, the revoke operation is still a POST
> whereas it should be a DELETE operation.
> Other than this, I think all API endpoints should be investigated and changed
> their HTTP method if needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
