[ https://issues.apache.org/jira/browse/KNOX-2665?focusedWorklogId=651721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-651721 ]
ASF GitHub Bot logged work on KNOX-2665: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Sep/21 14:16 Start Date: 16/Sep/21 14:16 Worklog Time Spent: 10m Work Description: zeroflag opened a new pull request #496: URL: https://github.com/apache/knox/pull/496 ## What changes were proposed in this pull request? There is a parse error in redirect.jsp ``` :8443/gateway/knoxss…/home/?refresh=1:49 Uncaught SyntaxError: Unexpected token ':' ``` This happens because the quotes are missing around the original url: ```js var originalUrl = <%= originalUrl %>; ``` So expression like this is generated into the html: ```js var originalUrl = https://localhost:8443/gateway/homepage/home/?refresh=1; ``` ## How was this patch tested? Manually triggered the redirect with logging into knox. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 651721) Remaining Estimate: 0h Time Spent: 10m > Knox redirecting.jsp parsing error > ---------------------------------- > > Key: KNOX-2665 > URL: https://issues.apache.org/jira/browse/KNOX-2665 > Project: Apache Knox > Issue Type: Task > Reporter: Attila Magyar > Assignee: Attila Magyar > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > A bug was recently introduced in redirecting.jsp whereby there is a parsing > error because the server-side value reference on line 68 is not quoted. > {code:java} > var originalUrl = <%= originalUrl %>; > {code} > It should rather be > {code:java} > var originalUrl = "<%= originalUrl %>";{code} -- This message was sent by Atlassian Jira (v8.3.4#803005)