[
https://issues.apache.org/jira/browse/KNOX-2777?focusedWorklogId=792718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792718
]
ASF GitHub Bot logged work on KNOX-2777:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/22 14:13
Start Date: 19/Jul/22 14:13
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #608:
URL: https://github.com/apache/knox/pull/608#discussion_r924449899
##########
gateway-util-common/src/main/java/org/apache/knox/gateway/util/ConcurrentSessionVerifier.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.util;
+
+
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+public class ConcurrentSessionVerifier {
Review Comment:
Instead of using static methods and static fields, let's have a normal non
static class with instance variables and non static methods. ~~Constants like
`privilegedUserConcurrentSessionLimit`/`privilegedUserConcurrentSessionLimit`
should be kept as statics but~~ `concurrentSessionCounter` should be non static.
Then we can create one instance of this class and use that at each places
where needed. Either by creating an instance somewhere in GatewayServer's
`main()` and passing that around or by making a singleton. I prefer the former
but that's up to how the code is structured. We can decide that later when we
start using it.
Issue Time Tracking
-------------------
Worklog Id: (was: 792718)
Time Spent: 2h (was: 1h 50m)
> Implement concurrent session verifier
> -------------------------------------
>
> Key: KNOX-2777
> URL: https://issues.apache.org/jira/browse/KNOX-2777
> Project: Apache Knox
> Issue Type: Sub-task
> Components: Server
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The following needs to be implemented in the scope of this JIRA:
> * we need 4 new Gateway-level configurations:
> ** privileged user list (defaults to an empty collection)
> ** non-privileged user list (defaults to an empty collection)
> ** session limit for privileged users (defaults to 3)
> ** session limit for non-privileged users (defaults to 2)
> * In addition to the new configs, a verifier has to be implemented that
> enforces the following business logic: if a user is listed in the
> above-introduced privileged/non-privileged collection AND is about to pass a
> configured session limit the verification should fail. The verification
> should succeed if the given user is declared neither a privileged nor a
> non-privileged user.
> The new verifier implementation may be placed in the {{gateway-util-common}}
> project for now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
