[
https://issues.apache.org/jira/browse/KNOX-2778?focusedWorklogId=801656&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801656
]
ASF GitHub Bot logged work on KNOX-2778:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/22 10:37
Start Date: 18/Aug/22 10:37
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #615:
URL: https://github.com/apache/knox/pull/615#discussion_r948945491
##########
gateway-server/src/main/resources/META-INF/services/org.apache.knox.gateway.services.ServiceFactory:
##########
@@ -30,4 +30,5 @@
org.apache.knox.gateway.services.factory.ServiceRegistryServiceFactory
org.apache.knox.gateway.services.factory.SslServiceFactory
org.apache.knox.gateway.services.factory.TokenServiceFactory
org.apache.knox.gateway.services.factory.TokenStateServiceFactory
-org.apache.knox.gateway.services.factory.TopologyServiceFactory
\ No newline at end of file
+org.apache.knox.gateway.services.factory.TopologyServiceFactory
+org.apache.knox.gateway.services.factory.ConcurrentSessionVerifierFactory
Review Comment:
nit: this list is an alphabetically-ordered list. The new service factory
should have been added in its appropriate line (line 20)
Issue Time Tracking
-------------------
Worklog Id: (was: 801656)
Time Spent: 5h (was: 4h 50m)
> Enforce concurrent session limit in KnoxSSO
> -------------------------------------------
>
> Key: KNOX-2778
> URL: https://issues.apache.org/jira/browse/KNOX-2778
> Project: Apache Knox
> Issue Type: Sub-task
> Components: Server
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Assignee: Balazs Marton
> Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Once, KNOX-2777 is ready, the next step is to wire that verifier
> implementation into the KnoxSSO flow such as it throws an authorization error
> (FORBIDDEN; 403) when a user tries to log in to UIs (both Knox's own UIs or
> UIs proxied by Knox) but that user exceeds the configured concurrent session
> limit.
> Basic logout handling should be covered too:
> * manually clicking on the logout button
> * subscribing to a session timeout event (you may want to talk to [~smore]
> about this)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
