[ 
https://issues.apache.org/jira/browse/KNOX-2850?focusedWorklogId=830694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830694
 ]

ASF GitHub Bot logged work on KNOX-2850:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Dec/22 17:25
            Start Date: 02/Dec/22 17:25
    Worklog Time Spent: 10m 
      Work Description: zeroflag commented on code in PR #688:
URL: https://github.com/apache/knox/pull/688#discussion_r1038363283


##########
pom.xml:
##########
@@ -1565,6 +1565,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-log4j12</artifactId>
                     </exclusion>
+                    <exclusion>

Review Comment:
   The `slf4j-reload4j` is the same as `slf4j-log4j12` but for reload4j (which 
is a up to date version of log4j one). Given that hadoop or other components 
might use slf4j for logging instead log4j (what knox uses) we need some kind of 
bridging library between those two. But this is for log4j1. So slf4j knows 
about how to log using Log4j/reload4j. But knox uses log4j2. So I don't think 
this is needed. I think the exclusion is fine.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 830694)
    Time Spent: 50m  (was: 40m)

> Take care of existing java upgrades by dependabot
> -------------------------------------------------
>
>                 Key: KNOX-2850
>                 URL: https://issues.apache.org/jira/browse/KNOX-2850
>             Project: Apache Knox
>          Issue Type: Task
>          Components: Server
>            Reporter: Sandor Molnar
>            Assignee: Marton Balázs
>            Priority: Major
>         Attachments: Screenshot 2022-12-01 at 11.22.23.png
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Similarly to KNOX-2834, there is a list of Java upgrades indicated by 
> Apache's {{dependabot}} which we need to upgrade in Knox (see attached 
> screenshot).
> Please upgrade them as listed and conduct a decent level of testing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to