lmccay commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1051440369
##########
gateway-provider-identity-assertion-common/pom.xml:
##########
@@ -97,7 +97,14 @@
<groupId>org.jboss.shrinkwrap</groupId>
<artifactId>shrinkwrap-api</artifactId>
</dependency>
-
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review Comment:
Does this also mean that ALL identity assertion providers now have a
dependency on hadoop common? That is a rather heavy dependency if not needed.
Guava is also problematic with mixed versions and stuff. If this wasn't already
a dependency then we will need to be careful with things like Ranger Knox
plugin coming into the mix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
