zeroflag commented on PR #734: URL: https://github.com/apache/knox/pull/734#issuecomment-1450200531
> Thanks, @zeroflag for submitting this cool change. As discussed offline, I think it'd be better if this logic was added in the HadoopXmlResourceParser for the following two reasons: > > * it's easy to add new unit test cases > * we may save some parser rounds Good points. I made the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org