[
https://issues.apache.org/jira/browse/KNOX-2890?focusedWorklogId=852597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-852597
]
ASF GitHub Bot logged work on KNOX-2890:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/23 15:22
Start Date: 23/Mar/23 15:22
Worklog Time Spent: 10m
Work Description: pzampino commented on code in PR #742:
URL: https://github.com/apache/knox/pull/742#discussion_r1146365404
##########
gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/AbstractHdfsHaDispatch.java:
##########
@@ -78,14 +60,35 @@ protected void executeRequest(HttpUriRequest
outboundRequest, HttpServletRequest
inboundResponse = executeOutboundRequest(outboundRequest);
writeOutboundResponse(outboundRequest, inboundRequest,
outboundResponse, inboundResponse);
} catch (StandbyException e) {
- LOG.errorReceivedFromStandbyNode(e);
- failoverRequest(outboundRequest, inboundRequest, outboundResponse,
inboundResponse, e);
+ /* if non-idempotent requests are not allowed to failover */
Review Comment:
This seems like it could be pulled out to a common method, or a
multi-Exception catch block since the handling is all exactly the same.
Issue Time Tracking
-------------------
Worklog Id: (was: 852597)
Time Spent: 40m (was: 0.5h)
> When client-knox connection is broken knox should not retry the same client
> request
> -----------------------------------------------------------------------------------
>
> Key: KNOX-2890
> URL: https://issues.apache.org/jira/browse/KNOX-2890
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 2.0..0
> Reporter: J.Andreina
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Knox should not be retrying non idempotent requests like POST, PATCH etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
