[
https://issues.apache.org/jira/browse/KNOX-2901?focusedWorklogId=858874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858874
]
ASF GitHub Bot logged work on KNOX-2901:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/23 08:53
Start Date: 25/Apr/23 08:53
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #750:
URL: https://github.com/apache/knox/pull/750#discussion_r1176212466
##########
gateway-topology-hadoop-xml/src/main/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceMonitor.java:
##########
@@ -97,6 +100,19 @@ private void processClouderaManagerDescriptor(String
descriptorFilePath, String
final HadoopXmlResourceParserResult result =
hadoopXmlResourceParser.parse(descriptorFilePath, topologyName);
processSharedProviders(result);
processDescriptors(result);
+ processDeleted(descriptorsDir, result.getDeletedDescriptors(), ".json");
+ processDeleted(topologiesDir, result.getDeletedDescriptors(), ".xml");
Review Comment:
As discussed offline, we may not need to remove topologies manually, because
there are supposed to be deleted by
[DescriptorsMonitor.onFileDelete](https://github.com/smolnar82/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/topology/monitor/DescriptorsMonitor.java#L67-L91).
Issue Time Tracking
-------------------
Worklog Id: (was: 858874)
Time Spent: 20m (was: 10m)
> Deleting a descriptor/provider from hadoop xml resource
> -------------------------------------------------------
>
> Key: KNOX-2901
> URL: https://issues.apache.org/jira/browse/KNOX-2901
> Project: Apache Knox
> Issue Type: Task
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Attachments: Screenshot 2023-04-19 at 13.23.04.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently one can only delete provider config parameters using the following
> syntax:
> {code}
> authentication.param.remove=main.pamRealm.service
> {code}
> But there is no way to remove an entire provider or descriptor.
> Proposed syntax:
> !Screenshot 2023-04-19 at 13.23.04.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
