[GitHub] [knox] zeroflag opened a new pull request, #757: KNOX-2912 - Don't fail over non idempotent requests unless it's a connect exception

[via GitHub]

zeroflag opened a new pull request, #757:
URL: https://github.com/apache/knox/pull/757

   ## What changes were proposed in this pull request?
   
   By default Knox doesn't fail over in case of non-idempotent requests. In 
case of a connect exception (connection refused, unknown host, etc), it is safe 
to failover since the connection hasn't been established yes and the request 
body was not consumed.
   
   ## How was this patch tested?
   
   Testet it manually with the following config:
   
   ```
       <provider>
            <role>ha</role>
            <name>HaProvider</name>
            <enabled>true</enabled>
            <param>
               <name>HIVE</name>
               
<value>enabled=true;maxFailoverAttempts=3;failoverSleep=1000</value>
            </param>
         </provider>
       </gateway>
   
       <service>
           <role>HIVE</role>
           <!-- <url>http://localhost:1700</url> -->
           <url>http://10.255.255.1:1234</url>
           <url>http://localhost:1701</url>
       </service>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org