moresandeep commented on code in PR #772:
URL: https://github.com/apache/knox/pull/772#discussion_r1267133229


##########
gateway-docker/src/main/resources/docker/Dockerfile:
##########
@@ -13,11 +13,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM openjdk:8-jre-alpine
+FROM openjdk:8-jre-alpine3.8

Review Comment:
   I tried using `eclipse-temurin:8-alpine`, there are TLS issues with 
   ```
   *   Trying 127.0.0.1:8443...
   * Connected to localhost (127.0.0.1) port 8443 (#0)
   * ALPN: offers h2,http/1.1
   * TLSv1.3 (OUT), TLS handshake, Client hello (1):
   * TLSv1.3 (IN), TLS alert, user canceled (346):
   * TLSv1.3 (IN), TLS alert, close notify (256):
   * OpenSSL SSL_connect: SSL_ERROR_ZERO_RETURN in connection to localhost:8443
   * Closing connection 0
   curl: (35) OpenSSL SSL_connect: SSL_ERROR_ZERO_RETURN in connection to 
localhost:8443
   ```
   
   I am not sure what the different is between this base image and the openjdk 
one but this appears broken (atleast as far as Knox is concerned). 
   
   Let me know if you have any concerns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to