zeroflag commented on code in PR #832:
URL: https://github.com/apache/knox/pull/832#discussion_r1453597300
##########
gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ServiceDeploymentContributorBase.java:
##########
@@ -82,7 +83,9 @@ protected void addAuthenticationFilter( DeploymentContext
context, Service servi
protected void addIdentityAssertionFilter( DeploymentContext context,
Service service, ResourceDescriptor resource) {
if( topologyContainsProviderType( context, "authentication" ) ||
topologyContainsProviderType( context, "federation" ) ) {
- context.contributeFilter( service, resource, "identity-assertion", null,
null );
+ Topology topology = context.getTopology();
+ Provider activeProvider = topology.getProvider("identity-assertion",
null);
Review Comment:
No, one line above there is a `topologyContainsProviderType` which does a
`context.getTopology().getProviders()`. If it was null it would fail even
earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
