[
https://issues.apache.org/jira/browse/KNOX-3000?focusedWorklogId=900139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900139
]
ASF GitHub Bot logged work on KNOX-3000:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/24 12:44
Start Date: 17/Jan/24 12:44
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #833:
URL: https://github.com/apache/knox/pull/833#discussion_r1455467805
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -287,6 +287,13 @@ public class GatewayConfigImpl extends Configuration
implements GatewayConfig {
private static final String
CLOUDERA_MANAGER_ADVANCED_SERVICE_DISCOVERY_CONF_MONITOR_INTERVAL =
GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.advanced.service.discovery.config.monitor.interval";
private static final String
CLOUDERA_MANAGER_SERVICE_DISCOVERY_REPOSITORY_CACHE_ENTRY_TTL =
GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.service.discovery.repository.cache.entry.ttl";
private static final String
CLOUDERA_MANAGER_SERVICE_DISCOVERY_MAX_RETRY_ATTEMPS =
GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.service.discovery.maximum.retry.attemps";
+ private static final String
CLOUDERA_MANAGER_SERVICE_DISCOVERY_CONNECT_TIMEOUT = GATEWAY_CONFIG_FILE_PREFIX
+ ".cloudera.manager.service.discovery.connect.timeout.msec";
+ private static final String CLOUDERA_MANAGER_SERVICE_DISCOVERY_READ_TIMEOUT
= GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.service.discovery.read.timeout.msec";
+ private static final String CLOUDERA_MANAGER_SERVICE_DISCOVERY_WRITE_TIMEOUT
= GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.service.discovery.write.timeout.msec";
+
+ private static final long
CLOUDERA_MANAGER_SERVICE_DISCOVERY_CONNECT_TIMEOUT_DEFAULT = 20000;
Review Comment:
Do you know if the default was 20 seconds earlier too? Or where this default
is coming from?
##########
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscoveryMessages.java:
##########
@@ -275,4 +275,7 @@ void roleConfigurationPropertyHasChanged(String
propertyName,
@Message(level = MessageLevel.DEBUG, text = "Found downscale event for role:
{0} hosts: {1}")
void foundDownScaleEvent(String role, Set<String> hosts);
+
+ @Message(level = MessageLevel.DEBUG, text = "Service discovery client
connect timeout {0}ms, read timeout {1}ms, write timeout {2}ms")
Review Comment:
I would set this one on `INFO` level and add a space before all `ms`
occurrences in the above `text` field.
Issue Time Tracking
-------------------
Worklog Id: (was: 900139)
Time Spent: 20m (was: 10m)
> Add configurable socket / read timeout parameter to discovery client
> --------------------------------------------------------------------
>
> Key: KNOX-3000
> URL: https://issues.apache.org/jira/browse/KNOX-3000
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We have an exposed retry parameter for the CM discovery client, but there is
> no way to set socket or read timeout parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
