zeroflag commented on code in PR #833:
URL: https://github.com/apache/knox/pull/833#discussion_r1455543584


##########
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscoveryMessages.java:
##########
@@ -275,4 +275,7 @@ void roleConfigurationPropertyHasChanged(String 
propertyName,
 
   @Message(level = MessageLevel.DEBUG, text = "Found downscale event for role: 
{0} hosts: {1}")
   void foundDownScaleEvent(String role, Set<String> hosts);
+
+  @Message(level = MessageLevel.DEBUG, text = "Service discovery client 
connect timeout {0}ms, read timeout {1}ms, write timeout {2}ms")

Review Comment:
   The `getClient()` is called before every service discovery. I can change it 
to `INFO` but then probably we should put the logging elsewhere to ensure that 
it's not called too frequently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to