zeroflag commented on code in PR #834: URL: https://github.com/apache/knox/pull/834#discussion_r1457211424
########## gateway-topology-simple/src/main/java/org/apache/knox/gateway/topology/simple/SimpleDescriptorHandler.java: ########## @@ -635,6 +635,15 @@ private static Map<String, File> generateTopology(final SimpleDescriptor desc, return result; } + /* + * First, undoes any previous manual XML escape. + * Second applies XML-escape on the result of the first step. + */ + private static String getXmlEscapedValue(String value) { + final String unescapedValue = StringEscapeUtils.unescapeXml(value); + return StringEscapeUtils.escapeXml10(unescapedValue); Review Comment: Is there a difference between `.escapeXml11` which was used before and `.escapeXml10`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org