smolnar82 commented on code in PR #826:
URL: https://github.com/apache/knox/pull/826#discussion_r1473947362
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java:
##########
@@ -457,4 +457,9 @@ private Collection<KnoxToken> fetchTokens(String userName,
boolean createdBy) {
});
return tokens;
}
+
+ @Override
+ public boolean isMigrationTarget() {
Review Comment:
Since the `DefaultTokenStateService` implements that method already, there
is no need to implement it everywhere. The only override of this method is
needed when you want to make that implementation a migration target. That's
what I did in `JDBCTokenStateService`.
From this point of view, making that class implement an interface or
override this method, doesn't make any difference, therefore I don't mind
changing to the interface approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
