risdenk commented on code in PR #840:
URL: https://github.com/apache/knox/pull/840#discussion_r1481919148
##########
gateway-provider-security-shiro/src/main/java/org/apache/knox/gateway/shirorealm/KnoxPamRealm.java:
##########
@@ -161,6 +149,23 @@ protected AuthenticationInfo
doGetAuthenticationInfo(AuthenticationToken token)
credentialsHash.getSalt(), getName());
}
+ private synchronized UnixUser lookupUnixUser(AuthenticationToken token) {
Review Comment:
This single threads all requests that use groups then right?
I know that libpam4j used to have threading issues under the hood. It might
be there are still issues there
see https://github.com/kohsuke/libpam4j/issues/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
