[
https://issues.apache.org/jira/browse/KNOX-3006?focusedWorklogId=904152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904152
]
ASF GitHub Bot logged work on KNOX-3006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/24 18:33
Start Date: 07/Feb/24 18:33
Worklog Time Spent: 10m
Work Description: risdenk commented on code in PR #840:
URL: https://github.com/apache/knox/pull/840#discussion_r1481919148
##########
gateway-provider-security-shiro/src/main/java/org/apache/knox/gateway/shirorealm/KnoxPamRealm.java:
##########
@@ -161,6 +149,23 @@ protected AuthenticationInfo
doGetAuthenticationInfo(AuthenticationToken token)
credentialsHash.getSalt(), getName());
}
+ private synchronized UnixUser lookupUnixUser(AuthenticationToken token) {
Review Comment:
This single threads all requests that use groups then right?
I know that libpam4j used to have threading issues under the hood. It might
be there are still issues there
see https://github.com/kohsuke/libpam4j/issues/28
Issue Time Tracking
-------------------
Worklog Id: (was: 904152)
Time Spent: 20m (was: 10m)
> PAM module occasionally generates garbage group names
> -----------------------------------------------------
>
> Key: KNOX-3006
> URL: https://issues.apache.org/jira/browse/KNOX-3006
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
