[
https://issues.apache.org/jira/browse/KNOX-3008?focusedWorklogId=906976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906976
]
ASF GitHub Bot logged work on KNOX-3008:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/24 15:25
Start Date: 26/Feb/24 15:25
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502803074
##########
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##########
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
We've been already using `InetAddress.getLocalHost().getHostName()` and
`InetAddress.getLocalHost().getCanonicalHostName()` at a couple of places in
the project.
I wonder how critical is to have the real hostname in cases like this. If
this is better we might need to consider replacing the existing references to
these `InetAddress` calls.
Otherwise if this is just a nice to have information, we might need to
think about using the existing idom, instead of introducing a new dependency.
Since adding a new dependency is always a liability, for future maintenance
and possible CVE point of view.
Issue Time Tracking
-------------------
Worklog Id: (was: 906976)
Time Spent: 40m (was: 0.5h)
> Add a new banner on the top of Knox UIs
> ---------------------------------------
>
> Key: KNOX-3008
> URL: https://issues.apache.org/jira/browse/KNOX-3008
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI, Homepage, TokenGenerationUI, TokenManagementUI
> Affects Versions: 2.1.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I got to know that Hue has a simple, but really cool feature: it can show a
> [custom HTML banner|https://gethue.com/add-a-top-banner-to-hue/] on the top
> of the Hue UI. Implementing a similar feature in Knox can help end-users to:
> # Share a message of the day like hints, tips, or planned outages.
> # Identify the cluster (e.g. Prod/Test/Dev) in case the URL is not clear
> enough.
> An additional improvement would be identifying which Knox gateway is in use,
> in case of HA deployments and if it's behind a load balancer, which can help
> with troubleshooting. This information fits perfectly into the existing
> {{General Proxy Information}} section on the Knox home page; we just need to
> add this new information as a new row in the table.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
