smolnar82 opened a new pull request, #861:
URL: https://github.com/apache/knox/pull/861

   ## What changes were proposed in this pull request?
   
   Before my change, any time I ran a KnoxCLI command I saw the following 
warning messages wrt. there are multiple SLF4J bindings on the classpath:
   ```
   $ bin/knoxcli.sh create-master --master gateway
   SLF4J: Class path contains multiple SLF4J bindings.
   SLF4J: Found binding in 
[jar:file:/Users/sandormolnar/test/knoxGateway/bin/../dep/log4j-slf4j-impl-2.17.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   SLF4J: Found binding in 
[jar:file:/Users/sandormolnar/test/knoxGateway/bin/../dep/logback-classic-1.2.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   Master secret has been persisted to disk.
   ```
   
   I also confirmed that we have had 
`ch.qos.logback:logback-[core-classic]:jar:1.2.10` on Maven's dependency tree 
multiple times.
   ```
   $ mvn dependency:tree | grep '^.*logback.*1.2.10.*$' | wc -l
         66
   ```
   
   ## How was this patch tested?
   
   1. Running the previous `mvn:dependencyTree` command:
   ```
   $ mvn dependency:tree | grep '^.*logback.*1.2.10.*$' | wc -l
          0
   ```
   2. Rebuilt and redeployed Knox, then ran the `create-master` command:
   ```
   $ bin/knoxcli.sh create-master --master gateway
   Master secret has been persisted to disk.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to